Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement to vertex attribute types for WebGPU #4777

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Improvement to vertex attribute types for WebGPU #4777

merged 1 commit into from
Oct 21, 2022

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Oct 21, 2022 •
edited
Loading

The types are added, but as glslang we currently use to transpile shaders from GL to WGL does not allow us to set the types in the shader, this does not work for existing shaders. We could:

  • read binary Spir-V shader and fix it
  • or perhaps convert data from whatever format they’re in to floats.

@mvaligursky mvaligursky self-assigned this Oct 21, 2022
@mvaligursky mvaligursky added the area: graphics Graphics related issue label Oct 21, 2022
@mvaligursky mvaligursky merged commit d035d6a into main Oct 21, 2022
@mvaligursky mvaligursky deleted the mv-webgpu-attribute-types branch October 21, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

@GSterbrant GSterbrant Awaiting requested review from GSterbrant

@slimbuck slimbuck Awaiting requested review from slimbuck

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @willeastcott