Return a sensible value for animation component duration if no animation is playing #4765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like returning 0 more I think, and using Debug.warn to let the user know. |
|
Yeah, I'm very torn on getting infinity errors 'silently' and not seeing it until it hits something that fires an exception (usually far away in the call stack from the actual cause) and actually giving a number that makes sense common use cases. If you still think it should be 0, I will change it but have the above concern. |
|
I understand, but a warning should solve the problem really. |
|
Updated PR to use 0 with warning |
mvaligursky
reviewed
Oct 19, 2022
mvaligursky
approved these changes
Oct 19, 2022
Co-authored-by: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stops exception being thrown when using duration if there is no animation playing
Returns
Number.MAX_VALUEinstead of 0 as some developers may be dividing by this number for a normalised value and this avoids divide by 0.A bit torn on whether this is the 'right' number to return though?
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.