New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShaderUtils class to provide common shader creation functionality #4746

Merged

mvaligursky merged 2 commits into main from mv-shader-utils

Oct 13, 2022

Contributor

mvaligursky commented Oct 13, 2022 •

edited

Loading

moved some common shader creation functionality to platform/graphics level to avoid some imports from scene/shader-lib
those functions are required by the Graphics engine to create some internal shaders
those functions are also used by the shader-lib to create shaders and cache them
also moved few related chunks to platform as well (webgpu, webgl2 ..)


          ShaderUtils class to provide common shader creation functionality

b6a25c1

mvaligursky self-assigned this

mvaligursky added enhancement area: graphics labels


          lint

8d9868a

mvaligursky requested review from willeastcott, slimbuck and GSterbrant

October 13, 2022 17:03

willeastcott approved these changes

View reviewed changes

mvaligursky merged commit d0c98b9 into main

mvaligursky deleted the mv-shader-utils branch

October 13, 2022 19:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels