Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved PROJECTION_*** constants from /scene to /core/shape #4735

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Moved PROJECTION_*** constants from /scene to /core/shape #4735

merged 1 commit into from
Oct 11, 2022

Conversation

mvaligursky
Copy link
Contributor

.. as the Frustum references them there

@mvaligursky mvaligursky self-assigned this Oct 11, 2022
@mvaligursky mvaligursky merged commit 8b93e82 into main Oct 11, 2022
@mvaligursky mvaligursky deleted the mv-projection-constants branch October 11, 2022 16:19
@willeastcott
Copy link
Contributor

willeastcott commented Oct 11, 2022 •
edited
Loading

I believe this is not the right approach here. IMHO, Frustum.getPoints should never have been added to this class. I think it's arguably better suited to being part of the Camera class. Possibly a non-API (@ignore) getter called Camera#frustumCorners.

@mvaligursky
Copy link
Contributor Author

I believe this is not the right approach here. IMHO, Frustum.getPoints should never have been added to this class. I think it's arguably better suited to being part of the Camera class. Possibly a non-API (@ignore) getter called Camera#frustumCorners.

You're totally right, I missed the frustum internally in the mentioned function even uses an instance of the camera. I'll have it done.

@willeastcott
Copy link
Contributor

Thanks @mvaligursky! U rock! 🙏

mvaligursky pushed a commit that referenced this pull request Oct 12, 2022
Revert "Moved PROJECTION_*** constants from /scene to /core/shape (#4735
ae70f43 
)"

This reverts commit 8b93e82.
@mvaligursky mvaligursky mentioned this pull request Oct 12, 2022
Merged
mvaligursky added a commit that referenced this pull request Oct 12, 2022
@mvaligursky @willeastcott
Moved camera related functionality from Frustum to Camera class (#4737)
1a6a173 
* Revert "Moved PROJECTION_*** constants from /scene to /core/shape (#4735)"

This reverts commit 8b93e82.

* moved function from frustum to camera

* lint

* Update src/scene/camera.js

Co-authored-by: Will Eastcott <will@playcanvas.com>

* defaults

Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
Co-authored-by: Will Eastcott <will@playcanvas.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott Awaiting requested review from willeastcott

@slimbuck slimbuck Awaiting requested review from slimbuck

Assignees

@mvaligursky mvaligursky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvaligursky @willeastcott @slimbuck