[Fix] Fix vertex shader attribute validation to support builtins #4695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimbuck
reviewed
Oct 5, 2022
mvaligursky
changed the title
mvaligursky
changed the title
slimbuck
reviewed
Oct 5, 2022
Co-authored-by: Donovan Hutchence <slimbuck7@gmail.com>
willeastcott
changed the title
willeastcott
reviewed
Oct 5, 2022
willeastcott
approved these changes
Oct 5, 2022
added 2 commits
October 5, 2022 11:51
…s/engine into mv-vertexid-validation
mvaligursky
added a commit
that referenced
this pull request
Oct 6, 2022
* [Fix] Improve shader attribute validation to support gl_VertexID * comment * additional builtins * Update src/graphics/webgl/webgl-shader.js Co-authored-by: Donovan Hutchence <slimbuck7@gmail.com> * moved Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com> Co-authored-by: Donovan Hutchence <slimbuck7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the error report and following null access when built in attributes, such as gl_VertexID or gl_InstanceID, are used in the vertex shader:
reported error:
ASSERT FAILED: Vertex shader attribute "gl_VertexID" is not mapped to a semantic in shader definition.