Fix GLB punctual lights with physical units #4691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes sky light intensity when using physical light units
Also fixes sky light intensity when using physical light units
…ine into gsterbrant_fix_glb_lights
mvaligursky
reviewed
Oct 3, 2022
mvaligursky
reviewed
Oct 3, 2022
mvaligursky
reviewed
Oct 3, 2022
Co-authored-by: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com>
mvaligursky
reviewed
Oct 3, 2022
mvaligursky
reviewed
Oct 3, 2022
mvaligursky
reviewed
Oct 3, 2022
mvaligursky
reviewed
Oct 4, 2022
…evel scene / resource layer.
mvaligursky
approved these changes
Oct 4, 2022
mvaligursky
added a commit
that referenced
this pull request
Oct 6, 2022
* Fixes glb physical light units Also fixes sky light intensity when using physical light units * Fixes glb physical light units Also fixes sky light intensity when using physical light units * Fix lint * Move calculation for light energy distribution to helper function. * Fix lint * Update src/scene/light.js Co-authored-by: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> * Lint * Periods * Simplified the code for setting the luminance value when loading GLBs * Move lightTypes lookup table from high level component layer to mid level scene / resource layer. * Simplify light intensity calculation internally for light like we do in the GLB * Fix lint Co-authored-by: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The GLB parser doesn't set the luminance parameter on the light entities it creates, resulting in no lights being visible in GLBs when physical lights are enabled.
This PR also fixes another bug where sky light intensity can't be 0 when physical units are enabled.