Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Texture related improvements to Gltf and USDZ Exporters #4690

Merged
merged 3 commits into from
Oct 3, 2022
Merged

Texture related improvements to Gltf and USDZ Exporters #4690

merged 3 commits into from
Oct 3, 2022

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Oct 3, 2022 •
edited
Loading

  • Gltf and USDZ exporters now support options
     * @param {object} options - Object for passing optional arguments.
     * @param {Color} [options.maxTextureSize] - Maximum texture size. Texture is resized if over the size.
  • Gltf exporter handles diffuse texture

source scene:
Screenshot 2022-10-03 at 12 34 50

exported glb:
Screenshot 2022-10-03 at 12 34 30

@mvaligursky mvaligursky self-assigned this Oct 3, 2022
@mvaligursky mvaligursky added enhancement area: graphics Graphics related issue labels Oct 3, 2022
mvaligursky and others added 2 commits October 3, 2022 14:00
@mvaligursky @willeastcott
Update extras/exporters/gltf-exporter.js
6c4a169 
Co-authored-by: Will Eastcott <will@playcanvas.com>
fixed type
469b463
@mvaligursky mvaligursky merged commit 503f8d1 into main Oct 3, 2022
@mvaligursky mvaligursky deleted the mvaligursky-exporters-improvements branch October 3, 2022 13:05
mvaligursky added a commit that referenced this pull request Oct 6, 2022
@mvaligursky @willeastcott
Texture related improvements to Gltf and USDZ Exporters (#4690)
4a0df07 
* Improvements to Gltf and USDZ Exporters - texture support

* Update extras/exporters/gltf-exporter.js

Co-authored-by: Will Eastcott <will@playcanvas.com>

* fixed type

Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
Co-authored-by: Will Eastcott <will@playcanvas.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

@slimbuck slimbuck Awaiting requested review from slimbuck

@GSterbrant GSterbrant Awaiting requested review from GSterbrant

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @willeastcott