Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements to physical lights units example #4679

Merged
merged 3 commits into from
Sep 29, 2022
Merged

Small improvements to physical lights units example #4679

merged 3 commits into from
Sep 29, 2022

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Sep 29, 2022 •
edited
Loading

Small updates:

  • camera bit closer
  • enabled area light, so the area light reflection is a rect shape
  • sizes / intensities
  • changed some HUD names to fit without clipping
  • wider panel to fit large range of values

Screenshot 2022-09-29 at 12 07 44

@mvaligursky mvaligursky self-assigned this Sep 29, 2022
willeastcott
willeastcott approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - looks much better!

@willeastcott
Copy link
Contributor

One minor point though. The UI panel labels are mostly truncated. Can we fix that perhaps?

@MAG-AdrianMeredith
Copy link
Contributor

am I reading that right that the shutter speed is set to 1 second? That seems like an odd value that would introduce a ton of motion blur if it were real

@mvaligursky
Copy link
Contributor Author

am I reading that right that the shutter speed is set to 1 second? That seems like an odd value that would introduce a ton of motion blur if it were real

For cameras, the units used for Shutter Speed are 1/x seconds, so in this case its 1/1000s

@mvaligursky mvaligursky merged commit 3f05a9e into main Sep 29, 2022
@mvaligursky mvaligursky deleted the mvaligursky-lights-example-tweaks branch September 29, 2022 11:12
mvaligursky added a commit that referenced this pull request Sep 29, 2022
@mvaligursky
Small improvements to physical lights units example (#4679)
ace337c 
* Small improvements to physical lights units example

* re-arranged labels + wider control panel to fit without clipping

* final cleanup

Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

@GSterbrant GSterbrant GSterbrant approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mvaligursky @willeastcott @MAG-AdrianMeredith @GSterbrant