Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLB parser - check for empty curveData path arrays #4665

Merged
merged 1 commit into from
Sep 23, 2022
Merged

GLB parser - check for empty curveData path arrays #4665

merged 1 commit into from
Sep 23, 2022

Conversation

ellthompson
Copy link
Contributor

Animation curves which contained no paths cause an error when parsing a GLB. The path array size should be checked before it is accessed.

Fixes #4613

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@ellthompson ellthompson added bug area: animation Animation related issue labels Sep 23, 2022
@ellthompson ellthompson requested a review from a team September 23, 2022 14:48
@ellthompson ellthompson self-assigned this Sep 23, 2022
@ellthompson ellthompson merged commit 15dd264 into main Sep 23, 2022
@ellthompson ellthompson deleted the glb-parser-fix branch September 23, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvaligursky mvaligursky mvaligursky approved these changes

Assignees

@ellthompson ellthompson

Labels
area: animation Animation related issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with parsing glb file when it has empty curveData.paths
2 participants
@ellthompson @mvaligursky