Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vector subtraction comments #4654

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Fix vector subtraction comments #4654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb7b33a
Fix incorrect method comments in vec2
Sep 21, 2022
3fb9d5f
Fix incorrect method comments in vec3
Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/math/vec2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,7 @@ class Vec2 {
/**
* Subtracts a 2-dimensional vector from another in place.
*
* @param {Vec2} rhs - The vector to add to the specified vector.
* @param {Vec2} rhs - The vector to subtract from the specified vector.
* @returns {Vec2} Self for chaining.
* @example
* var a = new pc.Vec2(10, 10);
Expand All @@ -501,8 +501,8 @@ class Vec2 {
/**
* Subtracts two 2-dimensional vectors from one another and returns the result.
*
* @param {Vec2} lhs - The first vector operand for the addition.
* @param {Vec2} rhs - The second vector operand for the addition.
* @param {Vec2} lhs - The first vector operand for the subtraction.
* @param {Vec2} rhs - The second vector operand for the subtraction.
* @returns {Vec2} Self for chaining.
* @example
* var a = new pc.Vec2(10, 10);
Expand Down
6 changes: 3 additions & 3 deletions src/math/vec3.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ class Vec3 {
/**
* Subtracts a 3-dimensional vector from another in place.
*
* @param {Vec3} rhs - The vector to add to the specified vector.
* @param {Vec3} rhs - The vector to subtract from the specified vector.
* @returns {Vec3} Self for chaining.
* @example
* var a = new pc.Vec3(10, 10, 10);
Expand All @@ -565,8 +565,8 @@ class Vec3 {
/**
* Subtracts two 3-dimensional vectors from one another and returns the result.
*
* @param {Vec3} lhs - The first vector operand for the addition.
* @param {Vec3} rhs - The second vector operand for the addition.
* @param {Vec3} lhs - The first vector operand for the subtraction.
* @param {Vec3} rhs - The second vector operand for the subtraction.
* @returns {Vec3} Self for chaining.
* @example
* var a = new pc.Vec3(10, 10, 10);
Expand Down