Adds a texture mapping allowing us to combine sampler uniforms #4636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All frontend chunks use the new textureMapping lookup to understand if the chunk needs to produce a new uniform sampler for its texture fetches or if the same texture is already declared as a sampler elsewhere.
willeastcott
approved these changes
Sep 14, 2022
slimbuck
reviewed
Sep 14, 2022
There was a problem hiding this comment.
Awesome PR @GSterbrant. I especially like that existing chunks are still supported (..right?).
Few things:
- please update chunk validation with updated API for frontend chunks
- please update chunk docs on developer site
slimbuck
reviewed
Sep 14, 2022
mvaligursky
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All frontend chunks use the new textureMapping lookup to understand if the chunk needs to output a new uniform sampler for its texture fetches or if the same texture is already declared as a sampler elsewhere. This solves a bug where some materials just fails to compile due to overuse of texture samplers.
For example, the glTF sample Stained Glass Lamp would fail to compile with clustered on using over 16 samplers, with this PR only uses 10.