-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added changeScene API #4626
Merged
Merged
Added changeScene API #4626
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
4142656
Added changeScene API
steveny-sc 2a80b76
Fixed scope issue
steveny-sc 439d7f8
Updated error message for when a scene cannot be found
steveny-sc 0cef99c
Updated deletion of all entities/nodes under app.root
steveny-sc b0941dd
Update src/framework/scene-registry.js
yaustar 61081f4
Update src/framework/scene-registry.js
yaustar 69d46ae
Reduce the number of property lookups
steveny-sc e27799b
Fixed missing self reference
steveny-sc 3bd4414
Merge branch 'change-scenes-api' of github.com:playcanvas/engine into…
steveny-sc 9b8853e
Removed trailing whitespace
steveny-sc 0abda98
LoadScene* functions now are able to take a scene name
steveny-sc 421b453
Added tests to find scene data by name and url
steveny-sc b7b2656
Moved to ES6 closures
steveny-sc 5948c02
Abstracted loadHierarchy to DRY
steveny-sc 79bcb76
Fixed bug where the wrong param was passed
steveny-sc 3a85de1
Removed uneeded extra function
steveny-sc dcd280f
Removed temp variable for closure
steveny-sc dd83a5b
Backwards compatibility fix for being able to use URLs that are not p…
steveny-sc 1777c31
Fixed ES6 function scope issue
steveny-sc c126b2d
Removed invalid test
steveny-sc 749604e
Update src/framework/scene-registry.js
yaustar 9e5ce5f
Update src/framework/scene-registry.js
yaustar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
app
closure variable also has too much context and maybe add JSDoc?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is JSDoc needed here for a private function that is only used in the scope of the current class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess its not needed, I just use them as a mind crutch and when the types are checked, it can offer some insight about what is going wrong in which position