Fix sheen glossiness and colour not getting applied correctly #4619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We disable the glossiness tinting when it's 1.0, but in glTF this value corresponds to roughness, so for glTFs, 0.0 should turn it off. Obviously, we don't know which shader chunk we are using so we have to just always enable sheen glossiness tinting.
willeastcott
approved these changes
Sep 5, 2022
mvaligursky
approved these changes
Sep 5, 2022
For some reason, this was overlooked in the previous PR, and we never set sheen glossiness or sheen colour textures.
slimbuck
reviewed
Sep 5, 2022
GSterbrant
changed the title
slimbuck
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bunch of issues with sheen. The first of which is that due to glossiness being roughness from glTF, we can't optimise the value out sheen glossiness tinting if the value is 1.0.
Furthermore, it turns out the sheen textures weren't even applied, so this PR fixes that as well.