Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Physically based light units #4618

Merged
merged 27 commits into from
Sep 23, 2022
Merged

Physically based light units #4618

merged 27 commits into from
Sep 23, 2022

Commits on Sep 22, 2022

  1. Add luminance to light. 

    Use luminance to calculate final light contribution before passing intensity and color to shader.
    @GSterbrant
    GSterbrant committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    2f69e3b View commit details
    Browse the repository at this point in the history

  2. Create example showing off physically based light and camera units

    @GSterbrant
    GSterbrant committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    10d97d6 View commit details
    Browse the repository at this point in the history

  3. Fix types.

    @GSterbrant
    GSterbrant committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    3f113a3 View commit details
    Browse the repository at this point in the history

  4. Changed name of example

    @GSterbrant
    GSterbrant committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    14b8953 View commit details
    Browse the repository at this point in the history

  5. Calculate spot light intensity as a function of inner and outer cone … 

    …angles.
    @GSterbrant
    GSterbrant committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    81a3fbd View commit details
    Browse the repository at this point in the history

  6. Fix model to render.

    @GSterbrant
    GSterbrant committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    cd5324e View commit details
    Browse the repository at this point in the history

  7. Clarified light luminance calculation code 

    Added documentation references to the calculation for the lux calculation for the light sources.
Changed from an if chain to switch to make it more clear the last condition is for directional lights.
    @GSterbrant
    GSterbrant committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    bc325e7 View commit details
    Browse the repository at this point in the history

  8. Fix lint

    @GSterbrant
    GSterbrant committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    7e05e3c View commit details
    Browse the repository at this point in the history

  9. Make sure inner angle also updates intensity.

    @GSterbrant
    GSterbrant committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    2bf89c7 View commit details
    Browse the repository at this point in the history

  10. Add internal flag to make sure lights calculate physical units 

    If the scene changes the physical units flag after the light is added, the lights will need their final color calculated to reflect that.
    @GSterbrant
    GSterbrant committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    52eb5b4 View commit details
    Browse the repository at this point in the history

  11. Fix lights physical units toggle

    @GSterbrant
    GSterbrant committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    05cd54a View commit details
    Browse the repository at this point in the history

  12. Flip the physical light switch only on visible lights

    @GSterbrant
    GSterbrant committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    09e62dc View commit details
    Browse the repository at this point in the history

  13. Realised the sky intensity wasn't correctly handled as a separate unit.

    @GSterbrant
    GSterbrant committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    c6354bf View commit details
    Browse the repository at this point in the history

  14. Added toggle for physical light units to example

    @GSterbrant
    GSterbrant committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    f1205f5 View commit details
    Browse the repository at this point in the history

  15. Fix compile issue

    @GSterbrant
    GSterbrant committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    d92e50b View commit details
    Browse the repository at this point in the history

  16. Move accessor out of inner loop.

    @GSterbrant
    GSterbrant committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    b213217 View commit details
    Browse the repository at this point in the history

  17. Add support for physically based luminance for ambient light

    @GSterbrant
    GSterbrant committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    3c2f800 View commit details
    Browse the repository at this point in the history

  18. Add comment for skyboxLuminance

    @GSterbrant
    GSterbrant committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    51d63dd View commit details
    Browse the repository at this point in the history

  19. Fix doc.

    @GSterbrant
    GSterbrant committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    d66db5d View commit details
    Browse the repository at this point in the history

  20. Add missing ambient light doc and apply.

    @GSterbrant
    GSterbrant committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    3dd8f13 View commit details
    Browse the repository at this point in the history

  21. Fix ambient luminance copy.

    @GSterbrant
    GSterbrant committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    f6bb56d View commit details
    Browse the repository at this point in the history

  22. Add switch for toggling skybox on/off (and using ambient light instead)

    @GSterbrant
    GSterbrant committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    b27faf0 View commit details
    Browse the repository at this point in the history

  23. Fix luts

    @GSterbrant
    GSterbrant committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    f1819d7 View commit details
    Browse the repository at this point in the history

  24. Added ambient light which will replace the sky when disabled.

    @GSterbrant
    GSterbrant committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    71bb6c6 View commit details
    Browse the repository at this point in the history

  25. Added comment about light luminance in component.

    @GSterbrant
    GSterbrant committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    08003f8 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2022

  1. Update src/scene/scene.js 

    Co-authored-by: Will Eastcott <will@playcanvas.com>
    @mvaligursky @willeastcott
    mvaligursky and willeastcott authored Sep 23, 2022
    Configuration menu
    Copy the full SHA
    57a970b View commit details
    Browse the repository at this point in the history

  2. Update src/scene/scene.js 

    Co-authored-by: Will Eastcott <will@playcanvas.com>
    @mvaligursky @willeastcott
    mvaligursky and willeastcott authored Sep 23, 2022
    Configuration menu
    Copy the full SHA
    55b7acf View commit details
    Browse the repository at this point in the history