AnimBinder path resolution update #4548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvaligursky
approved these changes
Aug 17, 2022
slimbuck
reviewed
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the AnimBinder to support two types of animation curve paths.
The first is currently supported in the engine and looks something like this:
This covers the case where the entity that the anim component is attached to (RootBone), is the parent of the GLB hierarchy to be animated. The GLB hierarchy in this instance starts at RootNode.
The second type of path which is supported in this PR looks like:
This will occur when the entity that the anim component is attached to (RootBone) is also the RootNode of the GLB hierachy which is being animated. FBX's loaded using the editor's import hierarchy feature will have this structure. The GLB hierarchy in this instance starts at RootBone.
Fixes: playcanvas/editor#602
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.