Morph target animation fix #4532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please explain what this does? you add the prefix, and later strip it. |
slimbuck
reviewed
Aug 12, 2022
| if (weightName.indexOf('name.') === 0) { | ||
| weightName = weightName.replace('name.', ''); | ||
| } else { | ||
| weightName = Number(weightName); |
There was a problem hiding this comment.
This will always be the index of the morph target as a string.
slimbuck
approved these changes
Aug 12, 2022
|
(approved, but pls wait for @mvaligursky to also approve before merging) |
The prefix is only added to morph target curves which are named via the mesh's extras property. This means we can differentiate them at binding time from indexed morph target curves, passing them to the setWeight function as a string instead of a number. Then those named curves will be referenced against the name lookup table, indexed curves will behave as before. |
mvaligursky
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Morph target animation curves that are named via the glb mesh's extras property should be differentiated from index based curves.
Fixes #4522
Fixes #4520
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.