Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

append action function #4469

Merged
merged 4 commits into from
Jul 25, 2022
Merged

append action function #4469

merged 4 commits into from
Jul 25, 2022

Conversation

jathu5
Copy link
Contributor

@jathu5 jathu5 commented Jul 23, 2022

Fixes #4468

Created function to add input controller actions instead of having to do same checks repeatedly. Also, fixed incorrect documentation.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@jathu5
Copy link
Contributor Author

jathu5 commented Jul 23, 2022

@yaustar Hey, until we verify the -button (#4463) issue, can we merge this pull request (fixes incorrect documentation and creates common function, but does not change the -button)?

@yaustar
Copy link
Contributor

yaustar commented Jul 25, 2022

Yeah, this looks like a clean refactor

@yaustar yaustar merged commit 419a719 into playcanvas:main Jul 25, 2022
@jathu5 jathu5 changed the title Append action append action function Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaustar yaustar yaustar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation Error
2 participants
@jathu5 @yaustar