Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom manifest in war/ subdirectory #71

Merged
merged 1 commit into from
Aug 16, 2012

Conversation

samspycher
Copy link
Contributor

A custom manifest in war/META-INF/MANIFEST.MF caused the build to fail, because it was colliding with the automatically generated manifest file. Now a MANIFEST.MF is only automatically generated if no custom file exists.

A custom manifest in war/META-INF/MANIFEST.MF caused the build to fail, because it was colliding with the automatically generated manifest file. Now a MANIFEST.MF is only automatically generated if no custom file exists.
@samspycher
Copy link
Contributor Author

A note to the code: I don't have much experience at all on Scala, and couldn't figure out how to do the case distinction with the option variable more elegantly... perhaps you can improve this?

Also, I made the search for MANIFEST.MF case-insensitive, since the spec for jar seems to reserve other cases also (see http://docs.oracle.com/javase/6/docs/technotes/guides/jar/jar.html, search for 'case-insensitive'), and I am unsure if certain containers would possibly also accept different casing.

@ghost ghost assigned dlecan Aug 9, 2012
dlecan added a commit that referenced this pull request Aug 16, 2012
Allow custom manifest in war/ subdirectory
@dlecan dlecan merged commit b26cdae into play2war:develop Aug 16, 2012
@dlecan
Copy link
Member

dlecan commented Aug 16, 2012

I will add later some debug informations.

@dlecan
Copy link
Member

dlecan commented Aug 21, 2012

Play2War v0.7.1 is out, including a fix for this issue.

@mdebusschere
Copy link

Is this valid for play 2.2.0 and play2-war-plugin 1.2-beta2 ?

Building on Windows 7 with Java 7.

Build fails due to conflict
[trace] Stack trace suppressed: run last *:war for the full output.
error java.util.zip.ZipException: duplicate entry: META-INF/MANIFEST.MF

Using custom web.xml files appears to work. Also, when I use a lowercase
filename manifest.mf, the WAR and ends up with TWO manifest.mf files.

@dlecan
Copy link
Member

dlecan commented Jan 14, 2014

@mdebusschere Please report a separate issue, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants