fix issue 289: Transfer-Encoding chunked header duplicated #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -102,6 +102,10 @@ trait HttpServletRequestHandler extends RequestHandler { | |||
| case (name, value) if name.equalsIgnoreCase(play.api.http.HeaderNames.SET_COOKIE) => | |||
| getServletCookies(value).foreach(httpResponse.addCookie) | |||
|
|
|||
| case (name, value) if name.equalsIgnoreCase(HeaderNames.TRANSFER_ENCODING) && value == HttpProtocol.CHUNKED => | |||
| // ignore this header | |||
| // the JEE container sets this header itself. Avoid duplication of header (issues/289) | |||
There was a problem hiding this comment.
Are we sure this header is set by all containers ?
Why did that work before ?
More, before what ? With Play 2.1.x ? Or with earlier versions of Tomcat ?
There was a problem hiding this comment.
actually, it is working because the header is duplicated. But most of HTTP clients deal with that.
It is only a trouble for some picky clients... ;)
As far as I know, the containers set this header automatically.
But I have not searched the JEE specs to check if the container must set this header.
It is a minor issue in my opinion.
dlecan
added a commit
that referenced
this pull request
Jul 8, 2015
…eader fix issue 289: Transfer-Encoding chunked header duplicated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.