Add payload to connect #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional changes: - The CONNECTED frame is sent before any SUBSCRIBE frames generated by the auto_subscribe option of the connect webhook. - Only valid User options returned by the connect webhook are applied to the user, rather than all of the returned options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most immediate impact of these changes is the addition of an extra argument to the javascript connect function, and the re-ordering of the CONNECTED and SUBSCRIBED (via auto_subscribe on connect) frames.
This also includes a fix for values returned by the connect webhook that are not actual user options (e.g. "auto_subscribe").