Feature: add repo_path_prefix argument for non-standard repo path.
#25
Conversation
There was a problem hiding this comment.
It looks like it's probably fine. Do you have a run with and without it showing how the error was fixed?
Also, what do you think @oleg-derevenetz?
action.yml
Outdated
| @@ -19,6 +19,10 @@ inputs: | |||
| description: 'The number of suggestions per comment (smaller numbers work better for heavy pull requests)' | |||
| required: false | |||
| default: '10' | |||
| repo_path_prefix: | |||
| description: 'The path to repo when codes are analyzed with clang-tidy' | |||
There was a problem hiding this comment.
Can you briefly specify the exact use case here?
We need to illustrate that users typically don't need that.
There was a problem hiding this comment.
We need to illustrate that users typically don't need that.
For users don't need that, the default setting works just like the former hard-coded bash script, and the implement details keep opaque for users.
Can you briefly specify the exact use case here?
It's necessary for users who run clang-tidy in a docker container. I considered this before, but it might be too long to put the introduction in the "description" field. Maybe providing a showcase for it in readme.md? What do you think?
There was a problem hiding this comment.
You can add something like may be needed for users who run clang-tidy in a docker container.
I understand that the default value will work for most, however those who dive in deeper shouldn't lose time looking into a parameter that may not concern them. :)
Also, can you also change when codes are analyzed to when code is analyzed? 🙏
There was a problem hiding this comment.
@platisd Sure! I've updated instructions as you suggested. Sorry for my English.
Here is the case with this patch. It worked as expected! |
Probably fixes #23 by setting
repo_path_prefixas/__wwhen using docker image for clang-tidy.P.S. I found it hard to describe this argument and its usage; any suggestions are welcomed.