Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using $GITHUB_WORKSPACE for base dir #24

Closed
wants to merge 1 commit into from
Closed

Conversation

caic99
Copy link
Contributor

@caic99 caic99 commented Apr 19, 2022

Probably fix #23 .

@platisd
Copy link
Owner

platisd commented Apr 19, 2022

Cool, do you have a run where this has worked without issues?

@oleg-derevenetz
Copy link
Contributor

oleg-derevenetz commented Apr 19, 2022

Just like I said, this will not work. This is the result of performing this action with the change you suggest for test PR:

https://github.com/oleg-derevenetz/fheroes2/runs/6074036612?check_suite_focus=true

please note that the printed value of GITHUB_WORKSPACE is wrong. This is the result of performing the original action with the same set of changes:

https://github.com/oleg-derevenetz/fheroes2/runs/6074169583?check_suite_focus=true

Please note that in the second case the corresponding warning was added to the PR:

oleg-derevenetz/fheroes2#76 (review)

@caic99
Copy link
Contributor Author

caic99 commented Apr 19, 2022

@oleg-derevenetz You are right, and thanks a lot for your test. I think this idea using GitHub env vars won't work, for it does not contain info between steps.
What do you guys think about setting '/home/runner/work/' as a parameter? For people using containers, just pass '/__w/' is OK.

@caic99 caic99 closed this Apr 19, 2022
@caic99 caic99 deleted the patch-1 branch April 19, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to match codes between repo and fixes.yml.
3 participants