-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
43 copy revisions #45
Conversation
in all deployed environments, the following correction should be made in the top box:
Fixed in commit 40b5174 |
in the initial production environment:
Fixed in commit de2f895 |
In the deployed staging environment:
Fixed in commit d9b3050 |
FYI: python backend fails to build due to issue with incorrect constraints on the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look ok, and I can most intuitively tell which step i'm at in the process as I progress but there are a couple of pieces that are still "broken"
Current state of MR. 2.Screen.Recording.2023-10-02.at.6.15.40.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gilzow - is there anything left that is critical on your side? would love to get this merged and then we can iterate over post-mvp launch changes in a new MR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to change git merge
to upsun merge
since we never actually instruct the user to perform a git merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think we're all good here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌞
Tasks