Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

43 copy revisions #45

Merged
merged 23 commits into from
Oct 3, 2023
Merged

43 copy revisions #45

merged 23 commits into from
Oct 3, 2023

Conversation

tylers-username
Copy link
Collaborator

@tylers-username tylers-username commented Sep 25, 2023

Tasks

@tylers-username tylers-username linked an issue Sep 25, 2023 that may be closed by this pull request
@tylers-username tylers-username self-assigned this Oct 2, 2023
@tylers-username tylers-username marked this pull request as ready for review October 2, 2023 15:46
@tylers-username tylers-username removed the request for review from chadwcarlson October 2, 2023 15:47
@tylers-username
Copy link
Collaborator Author

@gilzow @GuGuss I cannot assign myself as the reviewer. This branch includes the content that we intend to take to production.

@gilzow
Copy link
Collaborator

gilzow commented Oct 2, 2023

in all deployed environments, the following correction should be made in the top box:

Welcome to your Upsun Demo Guide project, a Python and Node.js multiapp designed to run on Upsun and teach you about it’s its unique features.

Fixed in commit 40b5174

@gilzow
Copy link
Collaborator

gilzow commented Oct 2, 2023

in the initial production environment:

This app is the React frontend of your demo project’s production environment, which is associated with the default branch of the repository: main. With it now deployed, we can add features, services, and runtimes from in preview environments - which are actually byte-for-byte copies of production.

Fixed in commit de2f895

@gilzow
Copy link
Collaborator

gilzow commented Oct 2, 2023

In the deployed staging environment:

This app uses the Upsun-provided environment variable $UPSUNPLATFORM_ENVIRONMENT="staging" to modify the content of this page.

Fixed in commit d9b3050

@gilzow
Copy link
Collaborator

gilzow commented Oct 2, 2023

FYI: python backend fails to build due to issue with incorrect constraints on the Werkzeug dependency in the upstream Flask repository. The Werkzeug is incorrectly being updated to version 3.0.0 which is incompatible with Flask <3.0.0 where ours is constrained to v2.0.1. We need to pin Werkzeug to v2.2.2 by adding a constraint to backend/requirements.txt:

Werkzeug==2.2.2

Copy link
Collaborator

@gilzow gilzow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look ok, and I can most intuitively tell which step i'm at in the process as I progress but there are a couple of pieces that are still "broken"

frontend/src/App.tsx Show resolved Hide resolved
frontend/src/App.tsx Outdated Show resolved Hide resolved
frontend/src/App.tsx Show resolved Hide resolved
frontend/src/App.tsx Outdated Show resolved Hide resolved
frontend/src/App.tsx Outdated Show resolved Hide resolved
@tylers-username
Copy link
Collaborator Author

Current state of MR.

2.Screen.Recording.2023-10-02.at.6.15.40.PM.mov

Copy link
Collaborator Author

@tylers-username tylers-username left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gilzow - is there anything left that is critical on your side? would love to get this merged and then we can iterate over post-mvp launch changes in a new MR.

frontend/src/App.tsx Outdated Show resolved Hide resolved
frontend/src/App.tsx Show resolved Hide resolved
frontend/src/App.tsx Outdated Show resolved Hide resolved
frontend/src/App.tsx Show resolved Hide resolved
frontend/src/App.tsx Outdated Show resolved Hide resolved
frontend/src/App.tsx Outdated Show resolved Hide resolved
frontend/src/App.tsx Outdated Show resolved Hide resolved
frontend/src/App.tsx Outdated Show resolved Hide resolved
frontend/src/App.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@gilzow gilzow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to change git merge to upsun merge since we never actually instruct the user to perform a git merge

frontend/src/App.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@tylers-username tylers-username left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we're all good here.

@tylers-username tylers-username requested review from gilzow and removed request for GuGuss October 3, 2023 18:19
Copy link

@Kazanir Kazanir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌞

@tylers-username tylers-username merged commit 14b2387 into main Oct 3, 2023
4 checks passed
@tylers-username tylers-username deleted the 43-copy-revisions branch October 3, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy revisions
4 participants