[noble] virdevmapper: Always use device name for finding targets #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virdevmapper: Always use device name for finding targets. This ensures that all the target devices of a multipath device are added to the namespace/cgroup of the guest domain. (LP: #2117467)
DM_TABLE_DEPS expects a device name in dm_ioctl.name. In one of the cases, full path of the device was getting returned causing the ioctl call to fail with `ENXIO (No such device or address)`. Also rename the function and variable names to better reflect that we are dealing with DM device names and not paths. This got introduced in 22494556542c676d1b9e7f1c1f2ea13ac17e1e3e Resolves: https://gitlab.com/libvirt/libvirt/-/issues/790 Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Signed-off-by: Bhavin Gandhi <bhavin192@geeksocket.in> Origin: upstream, https://gitlab.com/libvirt/libvirt/-/commit/bf8c7af771 Bug-Ubuntu: https://bugs.launchpad.net/libvirt/+bug/2117467 Last-Update: 2024-07-22
Signed-off-by: Bhavin Gandhi <bhavin@infracloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the version to ensure our downstream package is distinguishable.
Upstream bug: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/2117467
Docker script I used: