Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for nested virt on Nova Rocky+ #267

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for nested virt on Nova Rocky+ #267

wants to merge 2 commits into from

Conversation

mmccarre
Copy link
Contributor

No description provided.

@mmccarre mmccarre added the bug label Apr 23, 2020
@mmccarre mmccarre self-assigned this Apr 23, 2020
h00pz
h00pz previously approved these changes Apr 23, 2020
View reviewed changes
kphatak
kphatak suggested changes Apr 23, 2020
View reviewed changes
Copy link

@kphatak kphatak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really sure what line 10, 11 and 12 are required.

joshkelly
joshkelly approved these changes May 14, 2020
View reviewed changes
Copy link

@joshkelly joshkelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshkelly joshkelly requested a review from kphatak May 14, 2020 15:29
kphatak
kphatak approved these changes May 14, 2020
View reviewed changes
Copy link

@kphatak kphatak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshkelly joshkelly joshkelly approved these changes

@kphatak kphatak kphatak approved these changes

@h00pz h00pz h00pz approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@mmccarre mmccarre

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmccarre @joshkelly @kphatak @h00pz