This repository has been archived by the owner on Feb 22, 2019. It is now read-only.
Bucket region name correction for for us-east-1 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 32
💛 - Coveralls |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you very much for creating this fork and updating it! It really moved my work forward.
It so happened that I have a bucket in us-east-1. For legacy reasons, AWS SDK's method getBucketLocation does not return us-east-1 when asking about bucket in that region, but the string US instead. That behaviour is confirmed by AWS employee and reflected in the latest source code. So, for consistency, I propose the following change to address this issue.
I also took liberty to add target/ folder to .gitignore since the project is built with Maven.