Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Line Break at Document End No Longer Adds Blank Line at End of Empty Notes #1229

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

pjkaufman
Copy link
Collaborator

Fixes #1228

There was an issue/edge case in Line Break at Document End that was never really addressed. This issue was that an empty note would have a blank line added to it. This is not really the intent of the rule and is annoying when no other content is present. Thus it is being removed.

Changes Made:

  • Added an example showing this behavior (also counts as a UT)
  • Updated the logic in Line Break at Document End to return the current text if there is no content
  • Updated the rule description to mention that this is the case

… does not affect empty files and updated the description accordingly
@pjkaufman pjkaufman added the enhancement New feature or request label Nov 23, 2024
@pjkaufman pjkaufman self-assigned this Nov 23, 2024
@pjkaufman pjkaufman merged commit 5063adb into platers:master Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Option for Line Break at Document End to ignore empty files
1 participant