-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove enumerize #452
Remove enumerize #452
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small things, looks good!
:enumerize | ||
elsif rails_enum_attr? | ||
@enum_attr = if rails_enum_attr? | ||
:enum | ||
end | ||
|
||
raise "you need to pass an enumerize or enum attribute" unless @enum_attr | ||
raise "you need to pass an enum attribute" unless @enum_attr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with the change in display_data
, @enum_attr
is no longer used. We could chage this to just:
raise "you need to pass an enum attribute" unless rails_enum_attr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this whole file was for enumerize support, we should just delete it
In Platanus we have transitioned to using the standard Rails enums, which means that we are unable to continue supporting enumerize in this gem.