implement filters in nested select #300 #301
Conversation
There was a problem hiding this comment.
Thanks for the PR, it seems alright but I think there are some things that need to be addressed before we can merge:
- This change includes a new feature so there should be documentation for it, also it should be tested.
- Does this break when there are no filters? Did you consider that case?
Let us know!
My PR simply does something already documented in select2_nested_select.md for a long time but never implemented. |
| on_input_ctx("invoice_city_id") { expect_select2_selection("Colina") } | ||
| end | ||
|
|
||
| context "updating medium level" do |
There was a problem hiding this comment.
Start context description with 'when', 'with', or 'without'.
|
|
||
| create_cities | ||
| create_invoice(city: @colina) | ||
| visit edit_admin_invoice_path(@invoice) |
There was a problem hiding this comment.
Replace instance variable with local variable or let.
| end | ||
|
|
||
| create_cities | ||
| create_invoice(city: @colina) |
There was a problem hiding this comment.
Replace instance variable with local variable or let.
| level_2: { | ||
| attribute: :region_id, | ||
| # filters: { name_contains: 'Met' } | ||
| }, |
There was a problem hiding this comment.
Indent the right brace the same as the start of the line where the left brace is.
| level_1: { attribute: :country_id }, | ||
| level_2: { | ||
| attribute: :region_id, | ||
| # filters: { name_contains: 'Met' } |
There was a problem hiding this comment.
Incorrect indentation detected (column 28 instead of 30).
| f.input :city_id, as: :nested_select, | ||
| level_1: { attribute: :country_id }, | ||
| level_2: { | ||
| attribute: :region_id, |
There was a problem hiding this comment.
Avoid comma after the last item of a hash.
| end | ||
| end | ||
|
|
||
| context "without filters", focus: true do |
| on_input_ctx("invoice_city_id") { expect_select2_selection("Colina") } | ||
| end | ||
|
|
||
| context "updating medium level" do |
There was a problem hiding this comment.
Start context description with 'when', 'with', or 'without'.
|
|
||
| create_cities | ||
| create_invoice(city: @colina) | ||
| visit edit_admin_invoice_path(@invoice) |
There was a problem hiding this comment.
Replace instance variable with local variable or let.
| end | ||
|
|
||
| create_cities | ||
| create_invoice(city: @colina) |
There was a problem hiding this comment.
Replace instance variable with local variable or let.
| level_2: { | ||
| attribute: :region_id, | ||
| filters: { name_contains: 'Met' } | ||
| }, |
There was a problem hiding this comment.
Indent the right brace the same as the start of the line where the left brace is.
|
I added the tests as required. |
|
thank you! I'll review it as soon as I can! |
No description provided.