forked from microsoftgraph/microsoft-graph-toolkit
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle NewChat Errors, filter self from PeoplePicker (470) #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewDoing
requested review from
MattBillFred,
TechnicallyWilliams,
plasne,
kavithasreenath,
seekdavidlee and
salujamanish
February 15, 2024 20:48
rnbroadw
approved these changes
Feb 15, 2024
|
seekdavidlee
approved these changes
Feb 15, 2024
rnbroadw
approved these changes
Feb 16, 2024
TechnicallyWilliams
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Self chat is not supported, and various error conditions can occur with the NewChat component
This PR catches and logs those errors to console.
This PR also filters the PeoplePicker so that you can't select yourself. When self-chat is enabled by the Graph, this can be removed.
PR Type
Description of the changes
PR checklist
yarn build
) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense
)Other information