-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update react contoso to use chatlist per PG #42
Conversation
|
@@ -46,7 +46,7 @@ | |||
"watch:chat": "npm-run-all --parallel watch:chat-library watch:chat-library-deps watch:chat-test-app", | |||
"watch:components": "lerna run --parallel build:watch --scope @microsoft/mgt-components --include-dependents --include-dependencies", | |||
"watch:react-contoso": "lerna run start --scope react-contoso", | |||
"watch:react": "npm-run-all --parallel watch:components watch:react-contoso", | |||
"watch:react": "NODE_OPTIONS=--max_old_space_size=8192 npm-run-all --parallel watch:components watch:react-contoso", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be commited this to the upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking we should bring this up with Gavin. For now, I don't think its possible for anyone to run contoso without this setting - I did confirm with Gavin this setting helped me move pass the issue and he agreed.
There is a small outstanding CSS issue where u can select chat list item and the CSS on the page would be impacted. This is something we will cover with PG later.