fix timer cleanup #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seekdavidlee
requested review from
MattBillFred,
TechnicallyWilliams,
plasne,
kavithasreenath,
andrewDoing and
salujamanish
plasne
approved these changes
Jan 12, 2024
|
TechnicallyWilliams
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timer cleanups for both user and chat are stored in the same index db. When cleanup routine fires in either one of the user or chat clients, it would cleanup subscriptions for both. The subscription type now carries a componentType property. When querying we can specify componentType as either chat or user. This is done via in-memory filtering. Given we don't expect a high number of subscriptions to be returned because we only return expired subscriptions based on a timestamp (maybe 100 or less?), this approach should be performant enough.
There is an alternate design of using compound index, but it introduces complexity in the index/query. To keep it simple, I have opted for the in-memory filtering approach.