Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Chat Message Notifications (#316) #10

Merged
merged 15 commits into from
Jan 16, 2024
Merged

Handle Chat Message Notifications (#316) #10

merged 15 commits into from
Jan 16, 2024

Conversation

andrewDoing
Copy link
Collaborator

  • Shuffle appropriate ChatListItem to the top.
  • Add the ChatListItem and call load() if not in the list.
  • Update the preview message.
  • Change the class to "highlighted".
  • Call onMessageReceived() prop from PlexChat.
  • Validate
    | 'chatMessageReceived'

plasne
plasne reviewed Jan 12, 2024
View reviewed changes
packages/mgt-chat/src/components/ChatList/ChatList.tsx
};
if (chatListClient) {
chatListClient.onStateChange(setChatListState);
chatListClient.onChatListEvent(handleChatListEvent);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this old? I thought @seekdavidlee removed onChatListEvent()

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it back to handle this case, I'm guessing there's another way to accomplish this?

plasne
plasne requested changes Jan 12, 2024
View reviewed changes
Copy link
Owner

@plasne plasne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have a bunch of stuff from other PRs waiting to merge. I want to hold off approving until I see those merge and all that out of here. I think because some of this looks out-of-date.

@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-chat.src.statefulClient 100% 100% 0 ✔
mgt-chat.src.utils 100% 96% 0 ✔
mgt-components.dist.es6.components.mgt-agenda.src.components.mgt-agenda 12% 100% 0 ❌
mgt-components.dist.es6.components.mgt-contact.src.components.mgt-contact 62% 100% 0 ➖
mgt-components.dist.es6.components.mgt-file-list.mgt-file-upload.src.components.mgt-file-list.mgt-file-upload 43% 100% 0 ❌
mgt-components.dist.es6.components.mgt-file-list.src.components.mgt-file-list 51% 100% 0 ➖
mgt-components.dist.es6.components.mgt-file.src.components.mgt-file 46% 100% 0 ❌
mgt-components.dist.es6.components.mgt-get.src.components.mgt-get 20% 100% 0 ❌
mgt-components.dist.es6.components.mgt-login.src.components.mgt-login 63% 100% 0 ➖
mgt-components.dist.es6.components.mgt-messages.src.components.mgt-messages 65% 100% 0 ➖
mgt-components.dist.es6.components.mgt-organization.src.components.mgt-organization 46% 100% 0 ❌
mgt-components.dist.es6.components.mgt-people-picker.src.components.mgt-people-picker 49% 100% 0 ❌
mgt-components.dist.es6.components.mgt-people.src.components.mgt-people 59% 100% 0 ➖
mgt-components.dist.es6.components.mgt-person-card.src.components.mgt-person-card 53% 33% 0 ➖
mgt-components.dist.es6.components.mgt-person.src.components.mgt-person 48% 100% 0 ❌
mgt-components.dist.es6.components.mgt-picker.src.components.mgt-picker 75% 100% 0 ✔
mgt-components.dist.es6.components.mgt-profile.src.components.mgt-profile 39% 100% 0 ❌
mgt-components.dist.es6.components.mgt-tasks-base.src.components.mgt-tasks-base 76% 100% 0 ✔
mgt-components.dist.es6.components.mgt-tasks.src.components.mgt-tasks 54% 100% 0 ➖
mgt-components.dist.es6.components.mgt-taxonomy-picker.src.components.mgt-taxonomy-picker 62% 100% 0 ➖
mgt-components.dist.es6.components.mgt-teams-channel-picker.src.components.mgt-teams-channel-picker 55% 100% 0 ➖
mgt-components.dist.es6.components.mgt-theme-toggle.src.components.mgt-theme-toggle 74% 100% 0 ➖
mgt-components.dist.es6.components.mgt-todo.src.components.mgt-todo 80% 100% 0 ✔
mgt-components.dist.es6.components.preview.mgt-search-box.src.components.preview.mgt-search-box 74% 100% 0 ➖
mgt-components.dist.es6.components.preview.mgt-search-results.src.components.preview.mgt-search-results 51% 100% 0 ➖
mgt-components.dist.es6.components.preview.src.components.preview 100% 100% 0 ✔
mgt-components.dist.es6.components.src.components 82% 100% 0 ✔
mgt-components.dist.es6.components.sub-components.mgt-arrow-options.src.components.sub-components.mgt-arrow-options 70% 100% 0 ➖
mgt-components.dist.es6.components.sub-components.mgt-dot-options.src.components.sub-components.mgt-dot-options 28% 100% 0 ❌
mgt-components.dist.es6.components.sub-components.mgt-flyout.src.components.sub-components.mgt-flyout 40% 100% 0 ❌
mgt-components.dist.es6.components.sub-components.mgt-spinner.src.components.sub-components.mgt-spinner 92% 100% 0 ✔
mgt-components.dist.es6.graph.src.graph 36% 100% 0 ❌
mgt-components.dist.es6.src 100% 100% 0 ✔
mgt-components.dist.es6.styles.src.styles 73% 100% 0 ➖
mgt-components.dist.es6.utils.src.utils 45% 100% 0 ❌
mgt-components.src.components 81% 100% 0 ✔
mgt-components.src.components.mgt-contact 68% 83% 0 ➖
mgt-components.src.components.mgt-file 51% 100% 0 ➖
mgt-components.src.components.mgt-file-list 56% 100% 0 ➖
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 88% 0 ❌
mgt-components.src.components.mgt-messages 66% 100% 0 ➖
mgt-components.src.components.mgt-organization 47% 100% 0 ❌
mgt-components.src.components.mgt-person 79% 65% 0 ✔
mgt-components.src.components.mgt-person-card 66% 47% 0 ➖
mgt-components.src.components.mgt-profile 40% 100% 0 ❌
mgt-components.src.components.mgt-theme-toggle 100% 100% 0 ✔
mgt-components.src.components.sub-components.mgt-flyout 72% 53% 0 ➖
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0 ✔
mgt-components.src.graph 39% 89% 0 ❌
mgt-components.src.styles 92% 80% 0 ✔
mgt-components.src.utils 79% 28% 0 ✔
mgt-element.dist.es6.components.src.components 73% 81% 0 ➖
mgt-element.dist.es6.mock.src.mock 90% 72% 0 ✔
mgt-element.dist.es6.providers.src.providers 85% 69% 0 ✔
mgt-element.dist.es6.src 91% 80% 0 ✔
mgt-element.dist.es6.utils.src.utils 66% 69% 0 ➖
mgt-element.src 88% 100% 0 ✔
mgt-element.src.components 84% 100% 0 ✔
mgt-element.src.mock 81% 56% 0 ✔
mgt-element.src.providers 80% 85% 0 ✔
mgt-element.src.utils 71% 90% 0 ➖
Summary 57% (25322 / 44632) 66% (452 / 688) 0 ➖

@andrewDoing andrewDoing merged commit d97cd74 into next/mgt-chat Jan 16, 2024
7 checks passed
@andrewDoing andrewDoing deleted the andrewDoing/notification-316 branch January 16, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seekdavidlee seekdavidlee seekdavidlee left review comments

@plasne plasne plasne approved these changes

@TechnicallyWilliams TechnicallyWilliams TechnicallyWilliams approved these changes

@MattBillFred MattBillFred Awaiting requested review from MattBillFred

@kavithasreenath kavithasreenath Awaiting requested review from kavithasreenath

@salujamanish salujamanish Awaiting requested review from salujamanish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewDoing @TechnicallyWilliams @plasne @seekdavidlee