[Rust] Remove thread_init #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After fixing #110 the function
thread_initis not needed anymore.This PR removes the function, its usage in the crate and the out of date caveat. This is a breaking change to the API, but in because the crate has not reached version
1.xthis is considered ok in the Rust ecosystem (which tries to use SemVer). Before publishing to crates.io the crate version should be bumped to0.2.xto signal the a breaking change. If the breaking change is not desired another option is to leave a dummythread_initfunction that has no effect.The changes have been tested with one of my programs, the
toyexample and withcargo test.