Check period duration to be at least 1 day when using 'at'

plashchynski · Mar 15, 2015 · 95a237a · 95a237a
1 parent 6508197
commit 95a237a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/lib/crono/period.rb b/lib/crono/period.rb
@@ -47,6 +47,7 @@ def parse_on(on)
     end
 
     def parse_at(at)
+      fail "period should be at least 1 day to use 'at'" if @period < 1.day
       case at
       when String
         time = Time.parse(at)

diff --git a/spec/period_spec.rb b/spec/period_spec.rb
@@ -78,6 +78,12 @@
         }.to raise_error("Unknown 'at' format")
       end
 
+      it 'should raise error when period is less than 1 day' do
+        expect {
+          Crono::Period.new(5.hours, at: '15:30')
+        }.to raise_error("period should be at least 1 day to use 'at'")
+      end
+
       it 'should return time in relation to last time' do
         @period = Crono::Period.new(2.day)
         expect(@period.next(since: 1.day.ago)).to be_eql(1.day.from_now)