-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#119, #72: All elements and relationships can support hyperlinks (based on #126) #135
#119, #72: All elements and relationships can support hyperlinks (based on #126) #135
Conversation
…nIconic and tags (1 - legend update missing)
…ntUML internal line breaks are not deterministic)
…nIconic and tags (2 - incl legend) add procedures: AddRelTagSupport(), UpdateRelStyle() rename procedures: SHOW_DYNAMIC_LEGEND() to SHOW_LEGEND(), UpdateSkinparamsAndLegendEntry() to UpdateElementStyle()
…nIconic and tags (3 - update/add samples)
…nIconic and tags (4 - rename AddTagSupport() to AddElementTag(), AddRelTagSupport() to AddRelTag(), update img links)
…nIconic and tags (5 - skinparam arrow colors allows no #, resync percy files, fix build)
…nIconic and tags (6 - fix PR findings: remove obsolete code, update comments and use https urls)
…nIconic and tags (6a - fix PR finding: all files should end with empty line)
…ts (except relations) are updated
…emDb..., SystemQueue... are updated
…ips are updated, Readme.md extended
…- image with links is added as svg
…- add missing args in docu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look good. I haven't checked the www.plantuml.com/plantuml/ diagrams this time, though.
Considering the changes, I think a new version needs to be released before merging this |
@adrianvlupu I've taken the liberty of tagging v2.1.0. (and supplying milestones for all MRs/issues) Do you think we should also create a release branch? (As was done with v2.0.0, since files now link to |
@kirchsth Release is planned for my FOSS work this weekend. |
@kirchsth This has been released as v2.2.0. Before tagging the release, I did add 621a191 and 34353dd to make sure that Obviously, we should have seen this when reviewing this MR, but beter late than never, right? 😁 I would have liked to add more to that release but, because of 2 reviewers being needed, things will have to wait for |
@Potherca thank you for the extension, deprecated is a good idea |
Hi,
I created a new PR based on #126 with link support. It should cover #119 and #72.
I didn't merge the links support into #126 that the link extensions can be rejected.
I extended all calls with a $links="..." that all elements and relationships can have a link like below
The implementation can be checked via my extended branch
BR Helmut