Improve RegExp comparisons
#76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfaproject
reviewed
May 6, 2022
| export const areRegExpsEqual = (() => { | ||
| if (/foo/g.flags === 'g') { | ||
| return function areRegExpsEqual(a: RegExp, b: RegExp) { | ||
| return a.source === b.source && a.flags === b.flags; |
There was a problem hiding this comment.
Could the flags be in a different order? 'gm' vs 'mg'
There was a problem hiding this comment.
Based on the description in MDN, which is based on the spec, the flags are ordered alphabetically. Are you seeing different results?
There was a problem hiding this comment.
Nope, I was just wondering. Sorry for the noise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
The method used for comparing
RegExpvalues is robust, but not as fast as it could be because it does not use theflagsproperty when supported in new environments. As such, it also does not technically support newer flags.Change
Use the
flagsproperty when supported, else fall back to the original implementation.