Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I rewrote the action in TypeScript and swapped Github check runs for workflow command output powered annotations. This is a culmination of a lot of internal discussion, planning, and unexpected delays.
The core motivation is this: there have been longstanding issues with Github check runs initiated from Github actions, specifically that they get associated with the incorrect action run. Github now recommends using workflow output command annotations for situations like this.
There are also other issues we wanted to address:
Breaking changes
balto-eslint
display aneutral
conclusion.conclusion-level
ofsuccess
(the default) orfailure
to control how this affects the status of Github checks in the UI.Non-breaking changes
CONTRIBUTING.md
file to a section in theREADME.md
Notes for reviewing
There's a lot here! Sorry! Everything outside of
src/
andaction.yml
are just supporting files though.This should resolve #3 and #5