Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apple-touch-icon not found #948

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

knif3
Copy link
Contributor

@knif3 knif3 commented Nov 18, 2024

Description

Opening a project page directly by its URL link causes a 404 Not Found error for the http://planka/boards/logo192.png path.
If we open it from the main page, this basic part is already loaded and won't re-render after navigating, but accessing a specific project or card will render the whole HTML, therefore the relative logo192.png path will not be found there.

Fix

Simply added the %PUBLIC_URL% to the link component.

@CLAassistant
Copy link

CLAassistant commented Nov 18, 2024

CLA assistant check
All committers have signed the CLA.

@meltyshev meltyshev merged commit 1d11d9e into plankanban:master Nov 18, 2024
3 checks passed
@meltyshev
Copy link
Member

Thanks for the fix 🙏

@knif3 knif3 deleted the fix/icon-path branch November 19, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants