Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve courseupdate script #83

Merged
merged 7 commits into from
Feb 20, 2023
Merged

Improve courseupdate script #83

merged 7 commits into from
Feb 20, 2023

Conversation

nsandler1
Copy link
Member

@nsandler1 nsandler1 commented Jan 30, 2023

This PR slightly improves the readability of the course update script and addresses some bugs. Specifically:

  • originally, the alias would only be used if we had more than one professor with the same name and an alias existed. Instead, we want to check for aliases if we don't have record of a professor and an alias exists. This meant that before this pr, if you updated courses for some semester then ran it again for the same semester, almost all the same professors that were unverified the first time were unverified the second time. With this pr, running the script on the same semester a second time wouldn't create any new courses or any* new professors. (*with the one exception where a semester has professors with the same name)
  • assign professor variable a Professor object, not ProfessorAlias object
  • actually handle invalid UMD.io semesters

@nsandler1 nsandler1 added the priority Should be considered a priority label Feb 6, 2023
@tybug tybug merged commit a3321a7 into master Feb 20, 2023
@tybug tybug deleted the improve-courseupdate branch February 20, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority Should be considered a priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants