Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add suggestions on how to write reviews to /about #77

Merged
merged 6 commits into from
Jan 30, 2023
Merged

add suggestions on how to write reviews to /about #77

merged 6 commits into from
Jan 30, 2023

Conversation

nsandler1
Copy link
Member

No description provided.

@nsandler1 nsandler1 linked an issue Jan 29, 2023 that may be closed by this pull request
Rewrite "review criteria" section on /about #76
Closed
@nsandler1 nsandler1 mentioned this pull request Jan 30, 2023
Merged
tybug
tybug reviewed Jan 30, 2023
View reviewed changes
Copy link
Contributor

@tybug tybug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed some relatively uncontroversial copy editing changes (but do feel free to double check them). Two other comments besides that.

home/templates/about.html Outdated Show resolved Hide resolved
home/templates/about.html Outdated Show resolved Hide resolved
tybug
tybug approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@tybug tybug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't really fit on /about, but let's stick it there for now. Maybe we can split off review-related things to a separate page.

@tybug tybug merged commit 63b8acd into master Jan 30, 2023
@tybug tybug deleted the review-tips branch January 30, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tybug tybug tybug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite "review criteria" section on /about
2 participants
@nsandler1 @tybug