Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add migration script to remove duplicate ProfessorCourse entries #71

Merged
merged 4 commits into from
Jan 14, 2023
Merged

add migration script to remove duplicate ProfessorCourse entries #71

merged 4 commits into from
Jan 14, 2023

Conversation

nsandler1
Copy link
Member

No description provided.

@nsandler1 nsandler1 mentioned this pull request Jan 10, 2023
Merged
3 tasks
@nsandler1 nsandler1 added the priority Should be considered a priority label Jan 10, 2023
tybug
tybug approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@tybug tybug left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had to spend a bit of time working through the code to determine intent due to no comments, but I've convinced myself this will do what we want. I've also pushed the comments I made while working through the code.

@nsandler1
Copy link
Member Author

Good idea, thanks! I changed some of the wording of the comments to improve the clarity of what they're saying. I also added one new comment

@tybug tybug merged commit 2bb3c71 into master Jan 14, 2023
@tybug tybug deleted the professor-course-dups branch January 14, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tybug tybug tybug approved these changes

Assignees
No one assigned
Labels
priority Should be considered a priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsandler1 @tybug