change when the review_update webhook sends #56
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OLD: the review_updates webhook would execute if
(Review.pending.count + Professor.pending.count) % WEBHOOK_FREQUENCY == 0
. This method would cause the webhook to execute inconsistently when users used the add_professor form because instead of increasing the count by 1, the count would increase by 2 which often skipped over numbers divisible by WEBHOOK_FREQUENCY. In other words, the sum in the above conditional statement would always be skewed byProfessor.pending.count
and never increased linearly.NEW: this PR would have the webhook execute if
Review.pending.count % WEBHOOK_FREQUENCY == 0
. Each time this code is called (in add_professor.py and professor.py), we compare the number of pending reviews and if there happens to be unverified professors when the message is getting ready to send, the message will indicate how many there are BUT this number doesn't affect when the message will send. Only the number of reviews affects that.