Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make reviews anonymous by default #154

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Make reviews anonymous by default #154

merged 1 commit into from
Mar 20, 2024

Conversation

idugan100
Copy link
Contributor

Currently, when an authenticated user writes a review, the default is that the review is not anonymous.

image

I think it is better to default to an anonymous review. It's no big deal if a review is unintentionally anonymous. It is an issue if the review unintentionally has the username visible.

tybug
tybug approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@tybug tybug left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I can get behind this. bonus points — but not required — for adding a toggle setting for this on the user's profile ("default reviews to anonymous?").

@idugan100
Copy link
Contributor Author

@tybug
That's a good idea. I'll make an issue to add that and see if I get to it.

@kandasamyc
I think this is ready to merge.

@kandasamyc kandasamyc merged commit d8a6ee2 into planetterp:master Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tybug tybug tybug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@idugan100 @tybug @kandasamyc