Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

size: drop redundant branch #38

Merged
merged 2 commits into from
May 26, 2022
Merged

size: drop redundant branch #38

merged 2 commits into from
May 26, 2022

Conversation

fenollp
Copy link
Contributor

@fenollp fenollp commented May 25, 2022

Signed-off-by: Pierre Fenoll pierrefenoll@gmail.com

@fenollp
size: drop redundant branch
93ba55a 
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
@fenollp
update generated code
4433bdb 
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
vmg
vmg approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@vmg vmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For those following at home, it's safe to call len on a nil slice.

@vmg vmg merged commit 1ef8ec0 into planetscale:main May 26, 2022
@fenollp fenollp deleted the opti-size branch May 26, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmg vmg vmg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fenollp @vmg