Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goreleaser: stop disabling CGO #498

Closed
wants to merge 1 commit into from
Closed

goreleaser: stop disabling CGO #498

wants to merge 1 commit into from

Conversation

nickvanw
Copy link
Contributor

Testing this out to see if everything builds properly even with cross-compilation.

Testing this out to see if everything builds properly even with cross-compilation.
@nickvanw nickvanw marked this pull request as ready for review May 10, 2022 21:43
@nickvanw nickvanw requested a review from a team as a code owner May 10, 2022 21:43
Copy link
Member

@iheanyi iheanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dbussink
Copy link
Collaborator

I don't think this will work out of the box, since you need the target environment C compiler available as well. I don't think there's any good stuff for that on macOS. https://github.com/goreleaser/goreleaser-cross-example has a whole example using Docker, but we'd have to run on macOS as the base I think and then all the other platforms in Docker (or still disable CGO for Linux / Windows).

@dbussink
Copy link
Collaborator

#523 is the alternative approach for this which I think would work.

@dbussink dbussink closed this Jun 29, 2022
@dbussink dbussink deleted the nickvanw/cgo branch June 29, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants