Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add makefile #628

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Add makefile #628

merged 2 commits into from
Sep 16, 2021

Conversation

beansgum
Copy link
Contributor

Using a makefile would enable building a binary with build flags & variables while targeting multiple os.

Sirmorrison
Sirmorrison reviewed Sep 15, 2021
View reviewed changes
Copy link
Contributor

@Sirmorrison Sirmorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to update the readme doc so we know exactly how to build using the makefile changes.

Sirmorrison
Sirmorrison reviewed Sep 15, 2021
View reviewed changes
Copy link
Contributor

@Sirmorrison Sirmorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
i get the error when i try to run make on windows.

@beansgum
Copy link
Contributor Author

@Sirmorrison it errors because you’re trying to build for freebsd and cross compilation isn’t possible yet.

Sirmorrison
Sirmorrison previously approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@Sirmorrison Sirmorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine.

@Sirmorrison Sirmorrison dismissed their stale review September 15, 2021 20:01

rebase needed

@beansgum
Add makefile
bc9e79a 
Using a makefile would enable building a binary with build flags &
variables while targeting multiple os.
@beansgum
Update readme
ae30702
@Sirmorrison Sirmorrison merged commit 74b7dbc into planetdecred:master Sep 16, 2021
song50119 pushed a commit to song50119/godcr that referenced this pull request Apr 24, 2022
@beansgum
Add makefile (planetdecred#628)
ac2cb6d 
* Add makefile

Using a makefile would enable building a binary with build flags &
variables while targeting multiple os.

* Update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sirmorrison Sirmorrison Sirmorrison approved these changes

@dreacot dreacot dreacot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beansgum @dreacot @Sirmorrison