use GetTransactions method for fetching tickets #567

oshorefueled · 2021-08-19T18:11:51Z

This PR replaces the use of getTicket method with GetTransactions to fetch wallet tickets. It uses different transaction filters to fetch tickets with different status.
Fix #546
Fix #580
Fix #570
Fix #474
Close #458

The ticket activity page and section on the overview page are commented out. The code implemented looks like a duplicate of the ticket list page and having it as part of the ticket module is redundant. I suggest that page be reviewed before it is added back as an accessible feature.

beansgum

The tickets page freezes the app a bit before opening.
Some of the tooltips added by Ticket hover #488 aren't showing

ui/load/ticket.go

ui/page/tickets/overview.go

ui/load/ticket.go

beansgum · 2021-08-20T07:01:10Z

ui/load/ticket.go

+		overview.Voted += ov.Voted
+	}
+
+	wl.MultiWallet.GetLowestBlockTimestamp()


What does this do?

beansgum · 2021-08-20T07:26:21Z

ui/load/ticket.go

+	}
+}
+
+func filterToStatus(txFilter int32) string {


It looks like dcrlibwallet tx filters can be referenced directly instead of converting to identical constants.

ui/page/tickets/list_page.go

ui/page/tickets/overview.go

ui/page/tickets/list_page.go

ui/page/tickets/purchase_modal.go

ui/page/tickets/utils.go

ui/values/dimensions.go

Sirmorrison · 2021-09-14T09:57:43Z

ui/window.go

@@ -291,7 +288,7 @@ func (win *Window) Loop(w *app.Window, shutdown chan int) {
 				break
 			}

-			win.updateStates(e.Resp)
+			// win.updateStates(e.Resp)


Remove if no longer needed.

found a bug

dreacot · 2021-09-14T23:50:22Z

Even after selecting a wallet with enough funds, the Review Purchase button is disabled

Sirmorrison

Any specific reason the ticket activity page was removed?
When you have only one ticket, the ticket is center aligned rather than being aligned to the top left corner of the screen.

if I click the purchase button without entering my spending password (N:B i needed a password for my wallet), it says Attempting to Purchase ticket (1) but no tickets are purchased.

I understand that we should be able to allow for an empty password but since I currently need a password and non was provided, which also did not allow the ticket to be purchase (i think so), I should get an error message of some sort stating that the ticket purchase was not successful.

Button color is not app default blue color.

Sirmorrison

After successfully purchasing as ticket, the staking record still shows 0 unmined tickets instead of 1.

Waiting a while, i see that i now have one unmined ticket as a live ticket, and one staking record however, in the view all ticket page, the ticket is shown as immature.

overview page

All tickets page

SO to narrow down the issues, the ticket overview page is only refreshed when i Navigate to another Page and then back to the ticket page.

I believe at this point, the OnResume() is called which updates the page.

Sirmorrison

Pr looks good with functionality.

Some observations.

On the all tickets page, the wallet name is not displayed on the ticket card.
When i hover on the wallet name from the ticket overview page, there is no tooltip pop up. This was earlier implemented inPR Ticket hover #488.

Ticket overview page.

all ticket page

This is the mock up

- remove unused methods - remove multiwallet methods that can be called directly from pages since pages already have multiwallet in the Load struct.

- add ticket methods for fetch different ticket types in the load package

- display correct tickets reward value

- add transactionItem to wrap ticket transaction and tooltips

- Apply shadow to more list items and back up seed bottom pane

- use GridLayout for tickets grid view to fix scrolling lag issues

- show ticket maturity progress and display correct value on time label - use correct progress bar and track colors - add TxStatus struct - sort ticket transactions and prioritize spent tickets

- add tooltip messages for all ticket statuses and format block time for voted and revoked tickets - fix bug where overview page shows the same details for all tickets - add ticket status and confirmations property to transactionItem struct - add shadow to tooltip and remove border stroke

…on tooltips

- Add second progress bar layout that fixes a border radius bug - Add shared data to transactionItem - Refresh window after loading data to remove lag in ui update - Use correct format for ticket maturity time

no longer needed

* clean up wallet/commands.go - remove unused methods - remove multiwallet methods that can be called directly from pages since pages already have multiwallet in the Load struct. * add ticket type and methods to load package * clean up ticket list page - add ticket methods for fetch different ticket types in the load package * resolve inactive button bug on ticket purchase modal * remove global ticket implementation * use dcrlibwallet staking PR * cleanup fetch ticket code * delete ticket file from load package * move tooltip initialization to onResume * Cleanup tickets overview page - display correct tickets reward value * Fix only tickets purchase tx showing as 'All' in tickets list page - add transactionItem to wrap ticket transaction and tooltips * Add shadow to LinearLayout - Apply shadow to more list items and back up seed bottom pane * Add GridLayout - use GridLayout for tickets grid view to fix scrolling lag issues * tickets: fix ticket cards layouts - show ticket maturity progress and display correct value on time label - use correct progress bar and track colors - add TxStatus struct - sort ticket transactions and prioritize spent tickets * Fix ticket status tooltip - add tooltip messages for all ticket statuses and format block time for voted and revoked tickets - fix bug where overview page shows the same details for all tickets - add ticket status and confirmations property to transactionItem struct - add shadow to tooltip and remove border stroke * Fix content displayed in ticket age, days to vote and maturity duration tooltips * Use transactionItem to populate tickets list values - Add second progress bar layout that fixes a border radius bug - Add shared data to transactionItem - Refresh window after loading data to remove lag in ui update - Use correct format for ticket maturity time * Fix popups and complete tx details not showing on tx overview page * Remove tickets activity page and unused util functions * Cleanup ticket purchase modal * Show error if selected ticket purchase account has insufficient balance * Process ticket purchase in review modal * Refresh tickets overview data after successful ticket purchase * Add tooltip to wallet name * Use dcrlibwallet master(31878a6) Co-authored-by: Olanrewaju Collins <ocollins444@gmail.com>

oshorefueled force-pushed the fetch_tickets branch from da28a70 to 27c5f8b Compare August 19, 2021 18:18

beansgum previously requested changes Aug 20, 2021

View reviewed changes

beansgum mentioned this pull request Aug 20, 2021

Remove timeframe of completion from expired tickets #570

Closed

beansgum reviewed Aug 20, 2021

View reviewed changes

ui/page/tickets/list_page.go Outdated Show resolved Hide resolved

beansgum reviewed Aug 20, 2021

View reviewed changes

ui/page/tickets/overview.go Outdated Show resolved Hide resolved

oshorefueled force-pushed the fetch_tickets branch from 322a4fa to 2a706cc Compare August 30, 2021 15:09

beansgum self-assigned this Sep 12, 2021

beansgum force-pushed the fetch_tickets branch 2 times, most recently from 2b19b50 to 633497b Compare September 13, 2021 08:27

Sirmorrison suggested changes Sep 14, 2021

View reviewed changes

beansgum force-pushed the fetch_tickets branch from 633497b to 256efd2 Compare September 14, 2021 10:46

dreacot previously approved these changes Sep 14, 2021

View reviewed changes

Sirmorrison mentioned this pull request Sep 15, 2021

Ticket page design details #458

Closed

Sirmorrison suggested changes Sep 15, 2021

View reviewed changes

Sirmorrison reviewed Sep 15, 2021

View reviewed changes

oshorefueled added 7 commits September 15, 2021 19:11

clean up wallet/commands.go

e2b99b7

- remove unused methods - remove multiwallet methods that can be called directly from pages since pages already have multiwallet in the Load struct.

add ticket type and methods to load package

7ee9ecf

clean up ticket list page

e85361f

- add ticket methods for fetch different ticket types in the load package

resolve inactive button bug on ticket purchase modal

e9ebe20

remove global ticket implementation

eac64b2

cleanup code

e048abf

use dcrlibwallet staking PR

2da1892

oshorefueled and others added 20 commits September 15, 2021 19:11

cleanup fetch ticket code

fad6722

delete ticket file from load package

cab4922

move tooltip initialization to onResume

963179a

Cleanup tickets overview page

5d44591

- display correct tickets reward value

Fix only tickets purchase tx showing as 'All' in tickets list page

8e0bec5

- add transactionItem to wrap ticket transaction and tooltips

Add shadow to LinearLayout

93ba65b

- Apply shadow to more list items and back up seed bottom pane

Add GridLayout

abcf5c6

- use GridLayout for tickets grid view to fix scrolling lag issues

tickets: fix ticket cards layouts

61f6336

- show ticket maturity progress and display correct value on time label - use correct progress bar and track colors - add TxStatus struct - sort ticket transactions and prioritize spent tickets

Fix content displayed in ticket age, days to vote and maturity durati…

b9c7923

…on tooltips

Use transactionItem to populate tickets list values

aea8c27

- Add second progress bar layout that fixes a border radius bug - Add shared data to transactionItem - Refresh window after loading data to remove lag in ui update - Use correct format for ticket maturity time

Fix popups and complete tx details not showing on tx overview page

94e2e71

Remove tickets activity page and unused util functions

9d29e92

Cleanup ticket purchase modal

26e5aeb

Resolve requested changes

b3c4349

Show error if selected ticket purchase account has insufficient balance

4cc99e7

Process ticket purchase in review modal

541b3bc

Refresh tickets overview data after successful ticket purchase

3bb1845

Add tooltip to wallet name

66442f4

Use dcrlibwallet master(31878a6)

acebd08

beansgum force-pushed the fetch_tickets branch from 82e74d8 to acebd08 Compare September 15, 2021 18:15

dreacot approved these changes Sep 15, 2021

View reviewed changes

Sirmorrison approved these changes Sep 15, 2021

View reviewed changes

Sirmorrison merged commit b68db77 into planetdecred:master Sep 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use GetTransactions method for fetching tickets #567

use GetTransactions method for fetching tickets #567

oshorefueled commented Aug 19, 2021 •

edited by Sirmorrison

Loading

beansgum left a comment

beansgum Aug 20, 2021 •

edited

Loading

beansgum Aug 20, 2021

Sirmorrison Sep 14, 2021

dreacot commented Sep 14, 2021

Sirmorrison left a comment

Sirmorrison left a comment

Sirmorrison left a comment

use GetTransactions method for fetching tickets #567

use GetTransactions method for fetching tickets #567

Conversation

oshorefueled commented Aug 19, 2021 • edited by Sirmorrison Loading

beansgum left a comment

Choose a reason for hiding this comment

beansgum Aug 20, 2021 • edited Loading

Choose a reason for hiding this comment

beansgum Aug 20, 2021

Choose a reason for hiding this comment

Sirmorrison Sep 14, 2021

Choose a reason for hiding this comment

dreacot commented Sep 14, 2021

Sirmorrison left a comment

Choose a reason for hiding this comment

Sirmorrison left a comment

Choose a reason for hiding this comment

Sirmorrison left a comment

Choose a reason for hiding this comment

oshorefueled commented Aug 19, 2021 •

edited by Sirmorrison

Loading

beansgum Aug 20, 2021 •

edited

Loading