Fix display the account name in the Inputs and the Outputs of the transaction #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuhalang
force-pushed
the
fix_account_name
branch
from
16ac567 to
6781780
Compare
oshorefueled
suggested changes
Jun 16, 2021
- Display the account names next to the input and output information on the transactions details page. - Display 'external' if the address does not belong to the wallet
tuhalang
force-pushed
the
fix_account_name
branch
from
6781780 to
b91ed40
Compare
oshorefueled
approved these changes
Jun 17, 2021
song50119
pushed a commit
to song50119/godcr
that referenced
this pull request
Apr 24, 2022
- Display the account names next to the input and output information on the transactions details page. - Display 'external' if the address does not belong to the wallet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The brackets () before the wallet name(Wallet-Main) should display the account name that owns the address or 'external' if the address does not belong to the wallet. But right now, it is empty as shown
So this PR will display the account name or 'external' if the address does not belong to the wallet
