Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import watch only wallet #318

Merged
merged 7 commits into from
Feb 28, 2021

Conversation

hyhydra0
Copy link
Contributor

This adds the import watch only wallet feature.
Fixes #291

ui/wallet_page.go Outdated Show resolved Hide resolved
ui/wallet_page.go Outdated Show resolved Hide resolved
ui/wallet_page.go Outdated Show resolved Hide resolved
go.sum Outdated
@@ -152,6 +152,7 @@ github.com/envoyproxy/go-control-plane v0.9.0/go.mod h1:YTl/9mNaCwkRvm6d1a2C3ymF
github.com/envoyproxy/go-control-plane v0.9.4/go.mod h1:6rpuAdCZL397s3pYoYcLgu1mIlRU8Am5FuJP05cCM98=
github.com/envoyproxy/protoc-gen-validate v0.1.0/go.mod h1:iSmxcyjqTsJpI2R4NaDN7+kN2VEUnK/pcBlmesArF7c=
github.com/fsnotify/fsnotify v1.4.7/go.mod h1:jwhsz4b93w/PPRr/qN1Yymfu8t87LnFCMoQvtojpjFo=
github.com/fsnotify/fsnotify v1.4.9 h1:hsms1Qyu0jgnwNXIxa+/V/PDsU6CfLf6CNO8H7IWoS4=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem like it should be here since there's no change to the go.mod file

@oshorefueled
Copy link
Contributor

oshorefueled commented Feb 16, 2021

UI BUGS

  • The extended key field doesn't get cleared after successfully importing a wallet.
  • After importing a watch-only wallet, the sync progress never reaches the "synced" state. I observed though that It gets to "Synced" after I navigate to the send page and I get a "Loading" screen. Below is a screenshot of the overview page not displaying a synced state.

Screenshot 2021-02-16 at 16 41 10

@hyhydra0 hyhydra0 force-pushed the import-watch-only-wallet branch from a2a89c1 to 9db3d67 Compare February 22, 2021 19:42
@oshorefueled
Copy link
Contributor

Watch only wallet should not be displayed when there's no wallet imported. Below is the current implementation
Screenshot 2021-02-24 at 18 11 06

Below is how it should be
Screenshot 2021-02-24 at 18 10 59

ui/wallet_page.go Show resolved Hide resolved
@hyhydra0 hyhydra0 force-pushed the import-watch-only-wallet branch from 9db3d67 to 2be5a21 Compare February 28, 2021 18:23
@oshorefueled oshorefueled merged commit 6757dcf into planetdecred:master Feb 28, 2021
song50119 pushed a commit to song50119/godcr that referenced this pull request Apr 24, 2022
* layout watch only wallets

* add watch only wallet menu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import watch-only wallet
3 participants